Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sherlock fix https://github.com/sherlock-audit/2023-03-Y2K-judging/issues/208 #137

Merged
merged 3 commits into from
May 8, 2023

Conversation

3xHarry
Copy link
Contributor

@3xHarry 3xHarry commented Apr 10, 2023

No description provided.

Copy link

@IAm0x52 IAm0x52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good. Carousel now directly uses the treasury address sent on factory

Copy link

@IAm0x52 IAm0x52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs additional changes to address Issue 110. Controller still sends to it's immutable address

@3xHarry 3xHarry force-pushed the sherlock-fix-13 branch from c6a4934 to 2721996 Compare May 8, 2023 18:59
@3xHarry 3xHarry merged commit b8ec328 into sherlock-fix-12 May 8, 2023
Copy link

@IAm0x52 IAm0x52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good. Controller has been updated to use treasury address from factory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants